rtc: ds1343: cleanup .remove
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Sat, 19 Oct 2019 20:49:41 +0000 (22:49 +0200)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Sat, 19 Oct 2019 20:56:11 +0000 (22:56 +0200)
It is not necessary to call device_init_wakeup(dev, false) in .remove as
device_del will take care of that. It is also not necessary to
devm_free_irq. Finally, dev_pm_clear_wake_irq can be called
unconditionally.

Link: https://lore.kernel.org/r/20191019204941.6203-9-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-ds1343.c

index 131f5fd..d21004a 100644 (file)
@@ -437,15 +437,7 @@ static int ds1343_probe(struct spi_device *spi)
 
 static int ds1343_remove(struct spi_device *spi)
 {
-       struct ds1343_priv *priv = spi_get_drvdata(spi);
-
-       if (spi->irq) {
-               dev_pm_clear_wake_irq(&spi->dev);
-               device_init_wakeup(&spi->dev, false);
-               devm_free_irq(&spi->dev, spi->irq, priv);
-       }
-
-       spi_set_drvdata(spi, NULL);
+       dev_pm_clear_wake_irq(&spi->dev);
 
        return 0;
 }