projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f5e13d7
)
memory: renesas-rpc-if: fix platform-device leak in error path
author
Johan Hovold
<johan@kernel.org>
Thu, 3 Mar 2022 18:06:32 +0000
(19:06 +0100)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Wed, 20 Apr 2022 07:34:18 +0000
(09:34 +0200)
commit
b452dbf24d7d9a990d70118462925f6ee287d135
upstream.
Make sure to free the flash platform device in the event that
registration fails during probe.
Fixes:
ca7d8b980b67
("memory: add Renesas RPC-IF driver")
Cc: stable@vger.kernel.org # 5.8
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link:
https://lore.kernel.org/r/20220303180632.3194-1-johan@kernel.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/memory/renesas-rpc-if.c
patch
|
blob
|
history
diff --git
a/drivers/memory/renesas-rpc-if.c
b/drivers/memory/renesas-rpc-if.c
index
8618702
..
2a4c1f9
100644
(file)
--- a/
drivers/memory/renesas-rpc-if.c
+++ b/
drivers/memory/renesas-rpc-if.c
@@
-579,6
+579,7
@@
static int rpcif_probe(struct platform_device *pdev)
struct platform_device *vdev;
struct device_node *flash;
const char *name;
+ int ret;
flash = of_get_next_child(pdev->dev.of_node, NULL);
if (!flash) {
@@
-602,7
+603,14
@@
static int rpcif_probe(struct platform_device *pdev)
return -ENOMEM;
vdev->dev.parent = &pdev->dev;
platform_set_drvdata(pdev, vdev);
- return platform_device_add(vdev);
+
+ ret = platform_device_add(vdev);
+ if (ret) {
+ platform_device_put(vdev);
+ return ret;
+ }
+
+ return 0;
}
static int rpcif_remove(struct platform_device *pdev)