vhost: Fix livepatch timeouts in vhost_worker()
authorJosh Poimboeuf <jpoimboe@kernel.org>
Fri, 24 Feb 2023 16:50:01 +0000 (08:50 -0800)
committerPeter Zijlstra <peterz@infradead.org>
Wed, 22 Mar 2023 16:09:29 +0000 (17:09 +0100)
Livepatch timeouts were reported due to busy vhost_worker() kthreads.
Now that cond_resched() can do livepatch task switching, use
cond_resched() in vhost_worker().  That's the better way to
conditionally call schedule() anyway.

Reported-by: Seth Forshee (DigitalOcean) <sforshee@kernel.org>
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Tested-by: Seth Forshee (DigitalOcean) <sforshee@kernel.org>
Link: https://lore.kernel.org/r/509f6ea6fe6505f0a75a66026ba531c765ef922f.1677257135.git.jpoimboe@kernel.org
drivers/vhost/vhost.c

index f11bdbe..822fbdb 100644 (file)
@@ -363,8 +363,7 @@ static int vhost_worker(void *data)
                        kcov_remote_start_common(dev->kcov_handle);
                        work->fn(work);
                        kcov_remote_stop();
-                       if (need_resched())
-                               schedule();
+                       cond_resched();
                }
        }
        kthread_unuse_mm(dev->mm);