ACPI: drop unnecessary local variable from acpi_system_write_wakeup_device()
authorCyril Roelandt <tipecaml@gmail.com>
Thu, 22 Nov 2012 22:20:31 +0000 (23:20 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 22 Nov 2012 22:20:31 +0000 (23:20 +0100)
The LEN variable is unsigned, therefore checking whether it is less than 0 is
useless. Also drop the LEN variable, since the COUNT parameter can be used
instead.

[rjw: Changed the subject.]
Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/proc.c

index 27adb09..ef98796 100644 (file)
@@ -362,16 +362,13 @@ acpi_system_write_wakeup_device(struct file *file,
        struct list_head *node, *next;
        char strbuf[5];
        char str[5] = "";
-       unsigned int len = count;
 
-       if (len > 4)
-               len = 4;
-       if (len < 0)
-               return -EFAULT;
+       if (count > 4)
+               count = 4;
 
-       if (copy_from_user(strbuf, buffer, len))
+       if (copy_from_user(strbuf, buffer, count))
                return -EFAULT;
-       strbuf[len] = '\0';
+       strbuf[count] = '\0';
        sscanf(strbuf, "%s", str);
 
        mutex_lock(&acpi_device_lock);