Do not use "No" prefix for boolean variables to make it simpler. NFC.
authorRui Ueyama <ruiu@google.com>
Tue, 2 Feb 2016 07:18:15 +0000 (07:18 +0000)
committerRui Ueyama <ruiu@google.com>
Tue, 2 Feb 2016 07:18:15 +0000 (07:18 +0000)
llvm-svn: 259472

lld/ELF/Writer.cpp

index 3d7c748..d7c82db 100644 (file)
@@ -391,14 +391,12 @@ void Writer<ELFT>::scanRelocs(
     // a relocation from an object file, but some relocations need no
     // load-time fixup when the final target is known. Skip such relocation.
     bool CBP = canBePreempted(Body, /*NeedsGot=*/false);
-    bool NoDynrel = Target->isRelRelative(Type) || Target->isSizeRel(Type) ||
-                    !Config->Shared;
-    if (!CBP && NoDynrel)
-      continue;
-
+    bool Dynrel = Config->Shared && !Target->isRelRelative(Type) &&
+                  !Target->isSizeRel(Type);
     if (CBP)
       Body->setUsedInDynamicReloc();
-    Out<ELFT>::RelaDyn->addReloc({&C, &RI});
+    if (CBP || Dynrel)
+      Out<ELFT>::RelaDyn->addReloc({&C, &RI});
   }
 }