elm dbus menu - handle return value of eldbus_message_iter_arguments_get
authorCarsten Haitzler (Rasterman) <raster@rasterman.com>
Mon, 8 Aug 2016 07:58:16 +0000 (16:58 +0900)
committerCarsten Haitzler (Rasterman) <raster@rasterman.com>
Mon, 8 Aug 2016 08:47:14 +0000 (17:47 +0900)
handle possible error return of eldbus_message_iter_arguments_get()
according to coverity CID 1353591. this should fix that.

src/lib/elementary/elm_dbus_menu.c

index 31078bf..13fab00 100644 (file)
@@ -401,8 +401,9 @@ _event_handle(Elm_DBus_Menu *dbus_menu, Eldbus_Message_Iter *iter, int *error_id
    Eldbus_Message_Iter *data;
    unsigned *timestamp;
 
-   eldbus_message_iter_arguments_get(iter, "isvu", &id, &event, &data,
-                                    &timestamp);
+   if (!eldbus_message_iter_arguments_get(iter, "isvu", &id, &event, &data,
+                                          &timestamp))
+     return EINA_FALSE;
    i = id;
    item = eina_hash_find(dbus_menu->elements, &i);
    if (!item)