[ Bug ] Fix coverity issues
authorskykongkong8 <ss.kong@samsung.com>
Wed, 31 Jan 2024 06:25:29 +0000 (15:25 +0900)
committerjijoong.moon <jijoong.moon@samsung.com>
Wed, 20 Mar 2024 06:19:29 +0000 (15:19 +0900)
- Fix non-const variables to const variables since their value is never changed in actual practice
- Use const auto & to avoid object copy

Resolves:
```
non-const type variable, but its value is never changed.
auto_causes_copy
```

**Self evaluation:**
1. Build test:     [X]Passed [ ]Failed [ ]Skipped
2. Run test:     [X]Passed [ ]Failed [ ]Skipped

Change-Id: Ib54e1a4406438c64c43eb2ab8768e8a47556f7d2
Signed-off-by: skykongkong8 <ss.kong@samsung.com>
nntrainer/tensor/manager.cpp
nntrainer/tensor/optimized_v2_planner.cpp

index 7d06be38da75ca6366148e30d9165d5a02342410..4de4b9070150c13be070ca6153b07775ed0f7846 100644 (file)
@@ -663,7 +663,6 @@ std::vector<Tensor *> Manager::requestWeightOptimizerVariables(
   const std::vector<TensorDim> &dims, const std::string &name,
   const TensorLifespan &lifespan, bool is_grad_clip,
   Tensor::Initializer initializer) {
-  auto const exec_order = weight_pool.getExecutionOrder(name);
 
   std::vector<Tensor *> ret;
   ret.reserve(dims.size());
index bc733faf1478804af8e1c2a02fb47fb9cb516ea3..56c64cbdc442813f18e41869cfdb774e0059e793 100644 (file)
@@ -241,7 +241,7 @@ size_t OptimizedV2Planner::planLayout(
 #endif
     for (auto &req : wgrad_requests) {
       for (unsigned int idx = 0; idx < wgrad_sorted_req.size(); idx++) {
-        auto const sr = wgrad_sorted_req[idx];
+        const auto &sr = wgrad_sorted_req[idx];
         bool merge = true;
         if (sr.mem_req->size >= req.size) {
           for (auto &interval : sr.start_end) {