net: ethernet: fec: remove redundant null check before clk_disable_unprepare()
authorZhang Changzhong <zhangchangzhong@huawei.com>
Mon, 7 Sep 2020 12:49:44 +0000 (20:49 +0800)
committerJakub Kicinski <kuba@kernel.org>
Mon, 7 Sep 2020 20:34:42 +0000 (13:34 -0700)
Because clk_prepare_enable() and clk_disable_unprepare() already checked
NULL clock parameter, so the additional checks are unnecessary, just
remove them.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Acked-by: Fugang Duan <fugang.duan@nxp.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/fec_main.c

index fb37816..c043afb 100644 (file)
@@ -1960,8 +1960,7 @@ failed_clk_ref:
                mutex_unlock(&fep->ptp_clk_mutex);
        }
 failed_clk_ptp:
-       if (fep->clk_enet_out)
-               clk_disable_unprepare(fep->clk_enet_out);
+       clk_disable_unprepare(fep->clk_enet_out);
 
        return ret;
 }