RDMA/core: Check for verbs callbacks before using them
authorKamal Heib <kamalheib1@gmail.com>
Fri, 27 Jul 2018 18:23:05 +0000 (21:23 +0300)
committerJason Gunthorpe <jgg@mellanox.com>
Tue, 31 Jul 2018 02:31:09 +0000 (20:31 -0600)
Make sure the providers implement the verbs callbacks before calling
them, otherwise return -EOPNOTSUPP.

Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/core/uverbs_cmd.c
drivers/infiniband/core/verbs.c

index d4c3bc0..b2af4ee 100644 (file)
@@ -2504,7 +2504,8 @@ ssize_t ib_uverbs_post_srq_recv(struct ib_uverbs_file *file,
                goto out;
 
        resp.bad_wr = 0;
-       ret = srq->device->post_srq_recv(srq, wr, &bad_wr);
+       ret = srq->device->post_srq_recv ?
+               srq->device->post_srq_recv(srq, wr, &bad_wr) : -EOPNOTSUPP;
 
        uobj_put_obj_read(srq);
 
index cde359d..5b76c7e 100644 (file)
@@ -479,6 +479,9 @@ static struct ib_ah *_rdma_create_ah(struct ib_pd *pd,
 {
        struct ib_ah *ah;
 
+       if (!pd->device->create_ah)
+               return ERR_PTR(-EOPNOTSUPP);
+
        ah = pd->device->create_ah(pd, ah_attr, udata);
 
        if (!IS_ERR(ah)) {