ALSA: echoaudio: Deletion of a check before release_and_free_resource()
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 2 Dec 2014 17:34:45 +0000 (18:34 +0100)
committerTakashi Iwai <tiwai@suse.de>
Tue, 2 Dec 2014 17:40:22 +0000 (18:40 +0100)
The release_and_free_resource() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/echoaudio/echoaudio.c

index 60e4003..21228ad 100644 (file)
@@ -1875,8 +1875,7 @@ static int snd_echo_free(struct echoaudio *chip)
        if (chip->dsp_registers)
                iounmap(chip->dsp_registers);
 
-       if (chip->iores)
-               release_and_free_resource(chip->iores);
+       release_and_free_resource(chip->iores);
 
 
        pci_disable_device(chip->pci);