fsl/fman: fix dereference null return value
authorFlorinel Iordache <florinel.iordache@nxp.com>
Mon, 3 Aug 2020 07:07:31 +0000 (10:07 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 3 Aug 2020 23:20:14 +0000 (16:20 -0700)
Check before using returned value to avoid dereferencing null pointer.

Fixes: 18a6c85fcc78 ("fsl/fman: Add FMan Port Support")
Signed-off-by: Florinel Iordache <florinel.iordache@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/fman/fman_port.c

index 87b26f0..c27df15 100644 (file)
@@ -1767,6 +1767,7 @@ static int fman_port_probe(struct platform_device *of_dev)
        struct fman_port *port;
        struct fman *fman;
        struct device_node *fm_node, *port_node;
+       struct platform_device *fm_pdev;
        struct resource res;
        struct resource *dev_res;
        u32 val;
@@ -1791,8 +1792,14 @@ static int fman_port_probe(struct platform_device *of_dev)
                goto return_err;
        }
 
-       fman = dev_get_drvdata(&of_find_device_by_node(fm_node)->dev);
+       fm_pdev = of_find_device_by_node(fm_node);
        of_node_put(fm_node);
+       if (!fm_pdev) {
+               err = -EINVAL;
+               goto return_err;
+       }
+
+       fman = dev_get_drvdata(&fm_pdev->dev);
        if (!fman) {
                err = -EINVAL;
                goto return_err;