ALSA: hda: ext: hdac_ext_controller: use helpers in loop
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Wed, 19 Oct 2022 16:21:06 +0000 (11:21 -0500)
committerTakashi Iwai <tiwai@suse.de>
Thu, 20 Oct 2022 12:31:06 +0000 (14:31 +0200)
No need to copy/paste code, use helper instead.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://lore.kernel.org/r/20221019162115.185917-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/hda/ext/hdac_ext_controller.c

index 80876b9..f521d28 100644 (file)
@@ -225,9 +225,7 @@ int snd_hdac_ext_bus_link_power_up_all(struct hdac_bus *bus)
        int ret;
 
        list_for_each_entry(hlink, &bus->hlink_list, list) {
-               snd_hdac_updatel(hlink->ml_addr, AZX_REG_ML_LCTL,
-                                AZX_ML_LCTL_SPA, AZX_ML_LCTL_SPA);
-               ret = check_hdac_link_power_active(hlink, true);
+               ret = snd_hdac_ext_bus_link_power_up(hlink);
                if (ret < 0)
                        return ret;
        }
@@ -246,9 +244,7 @@ int snd_hdac_ext_bus_link_power_down_all(struct hdac_bus *bus)
        int ret;
 
        list_for_each_entry(hlink, &bus->hlink_list, list) {
-               snd_hdac_updatel(hlink->ml_addr, AZX_REG_ML_LCTL,
-                                AZX_ML_LCTL_SPA, 0);
-               ret = check_hdac_link_power_active(hlink, false);
+               ret = snd_hdac_ext_bus_link_power_down(hlink);
                if (ret < 0)
                        return ret;
        }