io_uring: remove return from io_req_cqe_overflow()
authorPavel Begunkov <asml.silence@gmail.com>
Fri, 11 Aug 2023 12:53:44 +0000 (13:53 +0100)
committerJens Axboe <axboe@kernel.dk>
Fri, 11 Aug 2023 16:42:57 +0000 (10:42 -0600)
Nobody checks io_req_cqe_overflow()'s return, make it return void.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/8f2029ad0c22f73451664172d834372608ee0a77.1691757663.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/io_uring.c
io_uring/io_uring.h

index e969b4c..7595658 100644 (file)
@@ -813,15 +813,15 @@ static bool io_cqring_event_overflow(struct io_ring_ctx *ctx, u64 user_data,
        return true;
 }
 
-bool io_req_cqe_overflow(struct io_kiocb *req)
+void io_req_cqe_overflow(struct io_kiocb *req)
 {
        if (!(req->flags & REQ_F_CQE32_INIT)) {
                req->extra1 = 0;
                req->extra2 = 0;
        }
-       return io_cqring_event_overflow(req->ctx, req->cqe.user_data,
-                                       req->cqe.res, req->cqe.flags,
-                                       req->extra1, req->extra2);
+       io_cqring_event_overflow(req->ctx, req->cqe.user_data,
+                               req->cqe.res, req->cqe.flags,
+                               req->extra1, req->extra2);
 }
 
 /*
index 3aa208f..3dc0b6f 100644 (file)
@@ -39,7 +39,7 @@ enum {
 };
 
 struct io_uring_cqe *__io_get_cqe(struct io_ring_ctx *ctx, bool overflow);
-bool io_req_cqe_overflow(struct io_kiocb *req);
+void io_req_cqe_overflow(struct io_kiocb *req);
 int io_run_task_work_sig(struct io_ring_ctx *ctx);
 void io_req_defer_failed(struct io_kiocb *req, s32 res);
 void io_req_complete_post(struct io_kiocb *req, unsigned issue_flags);