projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a911ad1
)
net/sched: fix incorrect vlan_push_eth dest field
author
Louis Peens
<louis.peens@corigine.com>
Wed, 23 Mar 2022 09:25:06 +0000
(11:25 +0200)
committer
Jakub Kicinski
<kuba@kernel.org>
Wed, 23 Mar 2022 17:32:48 +0000
(10:32 -0700)
Seems like a potential copy-paste bug slipped in here,
the second memcpy should of course be populating src
and not dest.
Fixes:
ab95465cde23
("net/sched: add vlan push_eth and pop_eth action to the hardware IR")
Signed-off-by: Louis Peens <louis.peens@corigine.com>
Link:
https://lore.kernel.org/r/20220323092506.21639-1-louis.peens@corigine.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/net/tc_act/tc_vlan.h
patch
|
blob
|
history
diff --git
a/include/net/tc_act/tc_vlan.h
b/include/net/tc_act/tc_vlan.h
index
a97600f
..
904eddf
100644
(file)
--- a/
include/net/tc_act/tc_vlan.h
+++ b/
include/net/tc_act/tc_vlan.h
@@
-84,7
+84,7
@@
static inline void tcf_vlan_push_eth(unsigned char *src, unsigned char *dest,
{
rcu_read_lock();
memcpy(dest, rcu_dereference(to_vlan(a)->vlan_p)->tcfv_push_dst, ETH_ALEN);
- memcpy(
dest
, rcu_dereference(to_vlan(a)->vlan_p)->tcfv_push_src, ETH_ALEN);
+ memcpy(
src
, rcu_dereference(to_vlan(a)->vlan_p)->tcfv_push_src, ETH_ALEN);
rcu_read_unlock();
}