UBI: fix check for "too many bytes"
authorBrian Norris <computersforpeace@gmail.com>
Sat, 28 Feb 2015 10:23:28 +0000 (02:23 -0800)
committerSasha Levin <sasha.levin@oracle.com>
Sun, 17 May 2015 23:12:11 +0000 (19:12 -0400)
[ Upstream commit 299d0c5b27346a77a0777c993372bf8777d4f2e5 ]

The comparison from the previous line seems to have been erroneously
(partially) copied-and-pasted onto the next. The second line should be
checking req.bytes, not req.lnum.

Coverity CID #139400

Cc: stable <stable@vger.kernel.org>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
[rw: Fixed comparison]
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/mtd/ubi/cdev.c

index 59de69a24e406ca2c0fbc0fd34c2561e8696279c..3946d78e6a814dd0dc61c0cf77d0dee30545952e 100644 (file)
@@ -453,7 +453,7 @@ static long vol_cdev_ioctl(struct file *file, unsigned int cmd,
                /* Validate the request */
                err = -EINVAL;
                if (req.lnum < 0 || req.lnum >= vol->reserved_pebs ||
-                   req.bytes < 0 || req.lnum >= vol->usable_leb_size)
+                   req.bytes < 0 || req.bytes > vol->usable_leb_size)
                        break;
 
                err = get_exclusive(desc);