staging: mrst: Fix error handling in psbfb_create
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 21 Dec 2011 00:01:31 +0000 (02:01 +0200)
committerMarkus Lehtonen <markus.lehtonen@linux.intel.com>
Tue, 3 Jul 2012 09:29:09 +0000 (12:29 +0300)
The two goto labels for unwinding on error were inverted. Swap them
around.

Fixes a smatch error:
drivers/staging/mrst/drv/psb_fb.c:421 psbfb_create(82) error: we previously assumed 'fb' could be null (see line 368) (smatch)

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
drivers/staging/mrst/drv/psb_fb.c

index 34185b1..5f14dfb 100644 (file)
@@ -417,9 +417,9 @@ static int psbfb_create(struct psb_fbdev * fbdev, struct drm_fb_helper_surface_s
        mutex_unlock(&dev->struct_mutex);
 
        return 0;
-out_err0:
-       fb->funcs->destroy(fb);
 out_err1:
+       fb->funcs->destroy(fb);
+out_err0:
        mutex_unlock(&dev->struct_mutex);
        return ret;
 }