pwm: berlin: Don't check the return code of pwmchip_remove()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tue, 4 May 2021 13:25:37 +0000 (15:25 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Wed, 30 Jun 2021 17:12:18 +0000 (19:12 +0200)
pwmchip_remove() always returns 0. Don't use the value to make it
possible to eventually change the function to return void. This is a
good thing as pwmchip_remove() is usually called from a remove function
(mostly for platform devices) and their return value is ignored by the
device core anyhow.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-berlin.c

index c17d7e8..5537b5f 100644 (file)
@@ -256,12 +256,12 @@ static int berlin_pwm_probe(struct platform_device *pdev)
 static int berlin_pwm_remove(struct platform_device *pdev)
 {
        struct berlin_pwm_chip *bpc = platform_get_drvdata(pdev);
-       int ret;
 
-       ret = pwmchip_remove(&bpc->chip);
+       pwmchip_remove(&bpc->chip);
+
        clk_disable_unprepare(bpc->clk);
 
-       return ret;
+       return 0;
 }
 
 #ifdef CONFIG_PM_SLEEP