vfio-mdev: Remove flag FBINFO_DEFAULT from fbdev sample driver
authorThomas Zimmermann <tzimmermann@suse.de>
Sat, 15 Jul 2023 18:51:49 +0000 (20:51 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Mon, 24 Jul 2023 14:50:38 +0000 (16:50 +0200)
The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags
has been allocated to zero by framebuffer_alloc(). So do not set it.

Flags should signal differences from the default values. After cleaning
up all occurrences of FBINFO_DEFAULT, the token will be removed.

v2:
* fix commit message (Miguel)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Kirti Wankhede <kwankhede@nvidia.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-8-tzimmermann@suse.de
samples/vfio-mdev/mdpy-fb.c

index 3c8001b..cda477b 100644 (file)
@@ -162,7 +162,6 @@ static int mdpy_fb_probe(struct pci_dev *pdev,
        }
 
        info->fbops = &mdpy_fb_ops;
-       info->flags = FBINFO_DEFAULT;
        info->pseudo_palette = par->palette;
 
        ret = register_framebuffer(info);