gtk: Remove coordinates double-translation
authorBastien Nocera <hadess@hadess.net>
Wed, 5 May 2021 14:48:10 +0000 (16:48 +0200)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Thu, 6 May 2021 01:18:18 +0000 (01:18 +0000)
Remove our own translation in the mouse event capture code, as that
translation will be done through the navigation interface.

Tested by resizing the window created by:
gst-launch-1.0 -v videotestsrc ! navigationtest ! glupload ! glcolorconvert ! tee name=t  ! gtkglsink
and checking that the cursor follows the mouse as expected.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/974>

ext/gtk/gtkgstbasewidget.c

index 3ad7903..bc9cc02 100644 (file)
@@ -335,13 +335,8 @@ gtk_gst_base_widget_button_event (GtkWidget * widget, GdkEventButton * event)
       const gchar *key_type =
           event->type ==
           GDK_BUTTON_PRESS ? "mouse-button-press" : "mouse-button-release";
-      gdouble x, y;
-
-      gtk_gst_base_widget_display_size_to_stream_size (base_widget, event->x,
-          event->y, &x, &y);
-
       gst_navigation_send_mouse_event (GST_NAVIGATION (element), key_type,
-          event->button, x, y);
+          event->button, event->x, event->y);
     }
     g_object_unref (element);
   }
@@ -357,13 +352,8 @@ gtk_gst_base_widget_motion_event (GtkWidget * widget, GdkEventMotion * event)
 
   if ((element = g_weak_ref_get (&base_widget->element))) {
     if (GST_IS_NAVIGATION (element)) {
-      gdouble x, y;
-
-      gtk_gst_base_widget_display_size_to_stream_size (base_widget, event->x,
-          event->y, &x, &y);
-
       gst_navigation_send_mouse_event (GST_NAVIGATION (element), "mouse-move",
-          0, x, y);
+          0, event->x, event->y);
     }
     g_object_unref (element);
   }