Fixup for recent -fast-isel-abort change: code didn't match description
authorMehdi Amini <mehdi.amini@apple.com>
Sat, 28 Feb 2015 19:34:54 +0000 (19:34 +0000)
committerMehdi Amini <mehdi.amini@apple.com>
Sat, 28 Feb 2015 19:34:54 +0000 (19:34 +0000)
Level 1 should abort for all instructions but call/terminators/args.
Instead it was aborting only if the level was > 2

From: Mehdi Amini <mehdi.amini@apple.com>
llvm-svn: 230861

llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp

index 3506de0..d015b0b 100644 (file)
@@ -1282,16 +1282,19 @@ void SelectionDAGISel::SelectAllBasicBlocks(const Function &Fn) {
           continue;
         }
 
+        bool ShouldAbort = EnableFastISelAbort;
         if (EnableFastISelVerbose || EnableFastISelAbort) {
           if (isa<TerminatorInst>(Inst)) {
             // Use a different message for terminator misses.
             dbgs() << "FastISel missed terminator: ";
+            // Don't abort unless for terminator unless the level is really high
+            ShouldAbort = (EnableFastISelAbort > 2);
           } else {
             dbgs() << "FastISel miss: ";
           }
           Inst->dump();
         }
-        if (EnableFastISelAbort > 2)
+        if (ShouldAbort)
           // FastISel selector couldn't handle something and bailed.
           // For the purpose of debugging, just abort.
           llvm_unreachable("FastISel didn't select the entire block");