soc: imx8m: No need to put node when of_find_compatible_node() failed
authorAnson Huang <Anson.Huang@nxp.com>
Tue, 17 Mar 2020 01:37:33 +0000 (09:37 +0800)
committerShawn Guo <shawnguo@kernel.org>
Tue, 14 Apr 2020 13:51:58 +0000 (21:51 +0800)
No need to put node when of_find_compatible_node() failed, return
immediately to simplify the code.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
drivers/soc/imx/soc-imx8m.c

index 719e1f1..7b0759a 100644 (file)
@@ -53,11 +53,11 @@ static u32 __init imx8mq_soc_revision(void)
        struct device_node *np;
        void __iomem *ocotp_base;
        u32 magic;
-       u32 rev = 0;
+       u32 rev;
 
        np = of_find_compatible_node(NULL, NULL, "fsl,imx8mq-ocotp");
        if (!np)
-               goto out;
+               return 0;
 
        ocotp_base = of_iomap(np, 0);
        WARN_ON(!ocotp_base);
@@ -78,9 +78,8 @@ static u32 __init imx8mq_soc_revision(void)
        soc_uid |= readl_relaxed(ocotp_base + OCOTP_UID_LOW);
 
        iounmap(ocotp_base);
-
-out:
        of_node_put(np);
+
        return rev;
 }