Fix static analysis issues

Change-Id: I202fff30f54d5ebab946f73d4e8fa827b49b3e35

diff --git a/src/client/client-security-manager.cpp b/src/client/client-security-manager.cpp
index 64a593aaea39204c13242c11c3641560b21e60a1..005af57ede734b6a26ea08df66cfff9c6fac968b 100644 (file)
--- a/src/client/client-security-manager.cpp
+++ b/src/client/client-security-manager.cpp
@@ -665,9 +665,17 @@ static int security_manager_set_process_groups_internal(const std::vector<gid_t>
     size_t fi = 0, ai = 0, size = 0;
     gid_t forbg = -1, allog = -1;
     int ret;
-    gid_t grp[NGROUPS_MAX+1];
+    gid_t *grp = static_cast<gid_t*>(malloc(sizeof(gid_t) * (NGROUPS_MAX + 1)));
 
-    ret = getgroups(sizeof grp / sizeof *grp, grp);
+    if (!grp) {
+        LogError("Unable to allocate memory for supplementary groups");
+        return SECURITY_MANAGER_ERROR_MEMORY;
+    }
+
+       auto deleter = [&](gid_t* ptr){free(ptr);};
+    std::unique_ptr<gid_t, decltype(deleter)> scopedGidBuffer(grp, deleter);
+
+    ret = getgroups(NGROUPS_MAX + 1, grp);
     if (ret < 0) {
         LogError("Unable to get list of current supplementary groups: " <<
             GetErrnoString(errno));