Handle Archive::children's error proerly.
authorRui Ueyama <ruiu@google.com>
Fri, 11 Nov 2016 02:09:28 +0000 (02:09 +0000)
committerRui Ueyama <ruiu@google.com>
Fri, 11 Nov 2016 02:09:28 +0000 (02:09 +0000)
The previous code didn't make sense at all. Now an error condition
is handled with fatal(). Thanks to Mehdi for pointing out the issue.

llvm-svn: 286547

lld/ELF/Driver.cpp

index d60fd7d..3c893cb 100644 (file)
@@ -113,7 +113,7 @@ LinkerDriver::getArchiveMembers(MemoryBufferRef MB) {
     V.push_back(MBRef);
   }
   if (Err)
-    Error(Err);
+    fatal("Archive::children failed: " + toString(std::move(Err)));
 
   // Take ownership of memory buffers created for members of thin archives.
   for (std::unique_ptr<MemoryBuffer> &MB : File->takeThinBuffers())