video: vga16fb: Only probe for EGA and VGA 16 color graphic cards

The vga16fb framebuffer driver only supports Enhanced Graphics Adapter
(EGA) and Video Graphics Array (VGA) 16 color graphic cards.

But it doesn't check if the adapter is one of those or if a VGA16 mode
is used. This means that the driver will be probed even if a VESA BIOS
Extensions (VBE) or Graphics Output Protocol (GOP) interface is used.

This issue has been present for a long time but it was only exposed by
commit d391c5827107 ("drivers/firmware: move x86 Generic System
Framebuffers support") since the platform device registration to match
the {vesa,efi}fb drivers is done later as a consequence of that change.

All non-x86 architectures though treat orig_video_isVGA as a boolean so
only do the supported video mode check for x86 and not for other arches.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=215001
Fixes: d391c5827107 ("drivers/firmware: move x86 Generic System Framebuffers support")
Reported-by: Kris Karas <bugs-a21@moonlit-rail.com>
Cc: <stable@vger.kernel.org> # 5.15.x
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Tested-by: Kris Karas <bugs-a21@moonlit-rail.com>
Acked-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20220110095625.278836-3-javierm@redhat.com

diff --git a/drivers/video/fbdev/vga16fb.c b/drivers/video/fbdev/vga16fb.c
index e2757ff..96e312a 100644 (file)
--- a/drivers/video/fbdev/vga16fb.c
+++ b/drivers/video/fbdev/vga16fb.c
@@ -184,6 +184,25 @@ static inline void setindex(int index)
        vga_io_w(VGA_GFX_I, index);
 }
 
+/* Check if the video mode is supported by the driver */
+static inline int check_mode_supported(void)
+{
+       /* non-x86 architectures treat orig_video_isVGA as a boolean flag */
+#if defined(CONFIG_X86)
+       /* only EGA and VGA in 16 color graphic mode are supported */
+       if (screen_info.orig_video_isVGA != VIDEO_TYPE_EGAC &&
+           screen_info.orig_video_isVGA != VIDEO_TYPE_VGAC)
+               return -ENODEV;
+
+       if (screen_info.orig_video_mode != 0x0D &&      /* 320x200/4 (EGA) */
+           screen_info.orig_video_mode != 0x0E &&      /* 640x200/4 (EGA) */
+           screen_info.orig_video_mode != 0x10 &&      /* 640x350/4 (EGA) */
+           screen_info.orig_video_mode != 0x12)        /* 640x480/4 (VGA) */
+               return -ENODEV;
+#endif
+       return 0;
+}
+
 static void vga16fb_pan_var(struct fb_info *info, 
                            struct fb_var_screeninfo *var)
 {
@@ -1422,6 +1441,11 @@ static int __init vga16fb_init(void)
 
        vga16fb_setup(option);
 #endif
+
+       ret = check_mode_supported();
+       if (ret)
+               return ret;
+
        ret = platform_driver_register(&vga16fb_driver);
 
        if (!ret) {