net: dsa: mv88e6xxx: vlan_tci is __be16
authorAndrew Lunn <andrew@lunn.ch>
Sun, 5 Jul 2020 19:38:08 +0000 (21:38 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sun, 5 Jul 2020 22:43:01 +0000 (15:43 -0700)
The flow spec member vlan_tci is in network order. Hence comparisons
should be made again network order values.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/mv88e6xxx/chip.c

index 7627ea6..d995f5b 100644 (file)
@@ -1751,7 +1751,7 @@ static int mv88e6xxx_policy_insert(struct mv88e6xxx_chip *chip, int port,
        }
 
        if ((fs->flow_type & FLOW_EXT) && fs->m_ext.vlan_tci) {
-               if (fs->m_ext.vlan_tci != 0xffff)
+               if (fs->m_ext.vlan_tci != htons(0xffff))
                        return -EOPNOTSUPP;
                vid = be16_to_cpu(fs->h_ext.vlan_tci) & VLAN_VID_MASK;
        }