mt76: remove offchannel check in tx scheduling
authorFelix Fietkau <nbd@nbd.name>
Thu, 22 Aug 2019 08:08:56 +0000 (10:08 +0200)
committerFelix Fietkau <nbd@nbd.name>
Thu, 5 Sep 2019 15:42:32 +0000 (17:42 +0200)
tx queues are already disabled by mac80211 during scanning or other
off-channel activity. There is no need to repeat the check in mt76,
since scheduled queues are selected by mac80211 as well.

Signed-off-by: Balakrishna Bandi <b.balakrishna@globaledgesoft.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mac80211.c
drivers/net/wireless/mediatek/mt76/mt76.h
drivers/net/wireless/mediatek/mt76/tx.c

index 32ddbf0..fa481d2 100644 (file)
@@ -406,11 +406,6 @@ void mt76_set_channel(struct mt76_dev *dev)
        bool offchannel = hw->conf.flags & IEEE80211_CONF_OFFCHANNEL;
        int timeout = HZ / 5;
 
-       if (offchannel)
-               set_bit(MT76_OFFCHANNEL, &dev->state);
-       else
-               clear_bit(MT76_OFFCHANNEL, &dev->state);
-
        wait_event_timeout(dev->tx_wait, !mt76_has_tx_pending(dev), timeout);
 
        if (dev->drv->update_survey)
index 38f2b17..d67c6a2 100644 (file)
@@ -272,7 +272,6 @@ enum {
        MT76_STATE_MCU_RUNNING,
        MT76_SCANNING,
        MT76_RESET,
-       MT76_OFFCHANNEL,
        MT76_REMOVED,
        MT76_READING_STATS,
 };
index d7982aa..c22a05f 100644 (file)
@@ -427,8 +427,7 @@ mt76_txq_send_burst(struct mt76_dev *dev, struct mt76_sw_queue *sq,
                if (probe)
                        break;
 
-               if (test_bit(MT76_OFFCHANNEL, &dev->state) ||
-                   test_bit(MT76_RESET, &dev->state))
+               if (test_bit(MT76_RESET, &dev->state))
                        return -EBUSY;
 
                skb = mt76_txq_dequeue(dev, mtxq, false);
@@ -487,8 +486,7 @@ mt76_txq_schedule_list(struct mt76_dev *dev, enum mt76_txq_id qid)
                if (sq->swq_queued >= 4)
                        break;
 
-               if (test_bit(MT76_OFFCHANNEL, &dev->state) ||
-                   test_bit(MT76_RESET, &dev->state)) {
+               if (test_bit(MT76_RESET, &dev->state)) {
                        ret = -EBUSY;
                        break;
                }