scsi: qedf: Check for module unloading bit before processing link update AEN
authorSaurav Kashyap <skashyap@marvell.com>
Fri, 23 Aug 2019 09:52:40 +0000 (02:52 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 29 Aug 2019 22:51:19 +0000 (18:51 -0400)
Prevent race where we're removing the module and we get link update

Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qedf/qedf_main.c

index 50b1fa8..ab9a932 100644 (file)
@@ -533,6 +533,16 @@ static void qedf_link_update(void *dev, struct qed_link_output *link)
 {
        struct qedf_ctx *qedf = (struct qedf_ctx *)dev;
 
+       /*
+        * Prevent race where we're removing the module and we get link update
+        * for qed.
+        */
+       if (test_bit(QEDF_UNLOADING, &qedf->flags)) {
+               QEDF_ERR(&qedf->dbg_ctx,
+                        "Ignore link update, driver getting unload.\n");
+               return;
+       }
+
        if (link->link_up) {
                if (atomic_read(&qedf->link_state) == QEDF_LINK_UP) {
                        QEDF_INFO((&qedf->dbg_ctx), QEDF_LOG_DISC,