Correct method generation to account for SA1001.
authorJarl Gullberg <jarl.gullberg@gmail.com>
Fri, 28 Jul 2017 10:56:20 +0000 (12:56 +0200)
committerJarl Gullberg <jarl.gullberg@gmail.com>
Thu, 3 Aug 2017 09:50:42 +0000 (11:50 +0200)
src/Generator.Bind/CSharpSpecWriter.cs

index f9c00c7..003cc71 100644 (file)
@@ -662,15 +662,13 @@ namespace Bind
             if (f.Parameters.HasGenericParameters)
             {
                 sb.Append("<");
-                foreach (Parameter p in f.Parameters)
+                foreach (Parameter p in f.Parameters.Where(p  => p.Generic))
                 {
-                    if (p.Generic)
-                    {
-                        sb.Append(p.CurrentType);
-                        sb.Append(",");
-                    }
+                    sb.Append(p.CurrentType);
+                    sb.Append(", ");
                 }
-                sb.Remove(sb.Length - 1, 1);
+
+                sb.Remove(sb.Length - 2, 2);
                 sb.Append(">");
             }
 
@@ -679,12 +677,9 @@ namespace Bind
             if (f.Parameters.HasGenericParameters)
             {
                 sb.AppendLine();
-                foreach (Parameter p in f.Parameters)
+                foreach (Parameter p in f.Parameters.Where(p => p.Generic))
                 {
-                    if (p.Generic)
-                    {
-                        sb.AppendLine(String.Format("    where {0} : struct", p.CurrentType));
-                    }
+                    sb.AppendLine(String.Format("    where {0} : struct", p.CurrentType));
                 }
             }