net/mlx5: Disable devlink reload for lag devices
authorShay Drory <shayd@nvidia.com>
Thu, 31 Dec 2020 13:04:08 +0000 (15:04 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 4 Mar 2021 10:37:32 +0000 (11:37 +0100)
[ Upstream commit edac23c2b3d3ac64cfcd351087295893671adbf5 ]

Devlink reload can't be allowed on lag devices since reloading one lag
device will cause traffic on the bond to get stucked.
Users who wish to reload a lag device, need to remove the device from
the bond, and only then reload it.

Fixes: 4383cfcc65e7 ("net/mlx5: Add devlink reload")
Signed-off-by: Shay Drory <shayd@nvidia.com>
Reviewed-by: Moshe Shemesh <moshe@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/devlink.c

index 0450ab5f5f756907f14ad5a260227121a3072dab..bf5cf022e279da555b083763d478a3944b5ed8d9 100644 (file)
@@ -137,6 +137,11 @@ static int mlx5_devlink_reload_down(struct devlink *devlink, bool netns_change,
 {
        struct mlx5_core_dev *dev = devlink_priv(devlink);
 
+       if (mlx5_lag_is_active(dev)) {
+               NL_SET_ERR_MSG_MOD(extack, "reload is unsupported in Lag mode\n");
+               return -EOPNOTSUPP;
+       }
+
        switch (action) {
        case DEVLINK_RELOAD_ACTION_DRIVER_REINIT:
                mlx5_unload_one(dev, false);