spi: use sysfs_emit() for printing statistics and add trailing newline
authorHeiner Kallweit <hkallweit1@gmail.com>
Fri, 18 Feb 2022 13:58:35 +0000 (14:58 +0100)
committerMark Brown <broonie@kernel.org>
Fri, 18 Feb 2022 14:39:07 +0000 (14:39 +0000)
Use dedicated function sysfs_emit() that does some extra checking,
e.g. to ensure that no more than PAGESIZE bytes are written.
In addition add a trailing newline to the output, that makes it
better readable from the console.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/56e1588d-d53b-73e9-fdc8-7fe30bf91f11@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi.c

index 85f8ae4..cd4dc31 100644 (file)
@@ -143,7 +143,7 @@ static ssize_t spi_statistics_##name##_show(struct spi_statistics *stat, \
        unsigned long flags;                                            \
        ssize_t len;                                                    \
        spin_lock_irqsave(&stat->lock, flags);                          \
-       len = sprintf(buf, format_string, stat->field);                 \
+       len = sysfs_emit(buf, format_string "\n", stat->field);         \
        spin_unlock_irqrestore(&stat->lock, flags);                     \
        return len;                                                     \
 }                                                                      \