ecore_evas_wayland_common: keep the backword compatibility for wayland dnd handler
authorTaehyub Kim <taehyub.kim@samsung.com>
Mon, 18 May 2020 07:56:08 +0000 (07:56 +0000)
committerJongmin Lee <jm105.lee@samsung.com>
Mon, 25 May 2020 21:35:45 +0000 (06:35 +0900)
Keep the backword compatibility for wayland ECORE_WL2_EVENT_DATA_SOURCE_END event handler.
If we don't use this handler, the dnd is not ended when the drop item is dropped.
@fix

Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11846

src/modules/ecore_evas/engines/wayland/ecore_evas_wayland_common.c

index 732b82b..1109b7b 100644 (file)
@@ -3753,26 +3753,31 @@ _ecore_evas_wl_selection_init(Ecore_Evas *ee)
 {
    Ecore_Evas_Engine_Wl_Data *wdata = ee->engine.data;
 
-   wdata->changed_handler = ecore_event_handler_add(ECORE_WL2_EVENT_SEAT_SELECTION,
-                           _wl_selection_changed, ee);
-   wdata->send_handler = ecore_event_handler_add(ECORE_WL2_EVENT_DATA_SOURCE_SEND,
-                           _wl_interaction_send, ee);
-   wdata->offer_handler = ecore_event_handler_add(ECORE_WL2_EVENT_OFFER_DATA_READY,
-                           _wl_selection_receive, ee);
-   wdata->dnd_leave_handler = ecore_event_handler_add(ECORE_WL2_EVENT_DND_LEAVE,
-                           _wl_selection_dnd_leave, ee);
-   wdata->dnd_motion_handler = ecore_event_handler_add(ECORE_WL2_EVENT_DND_MOTION,
-                           _wl_selection_dnd_motion, ee);
-   wdata->dnd_enter_handler = ecore_event_handler_add(ECORE_WL2_EVENT_DND_ENTER,
-                           _wl_selection_dnd_enter, ee);
-   wdata->dnd_drop_handler = ecore_event_handler_add(ECORE_WL2_EVENT_DND_DROP,
-                           _wl_selection_dnd_drop, ee);
-   //TIZEN_ONLY(20200508): fix this for compatability of tizen 5.5
-   //wdata->dnd_end_handler = ecore_event_handler_add(ECORE_WL2_EVENT_DATA_SOURCE_DROP,
-   //                        _wl_selection_dnd_end, ee);
-   wdata->dnd_end_handler = ecore_event_handler_add(ECORE_WL2_EVENT_DATA_SOURCE_END,
-                           _wl_selection_dnd_end, ee);
-   //
+   wdata->changed_handler =
+     ecore_event_handler_add(ECORE_WL2_EVENT_SEAT_SELECTION,
+                             _wl_selection_changed, ee);
+   wdata->send_handler =
+     ecore_event_handler_add(ECORE_WL2_EVENT_DATA_SOURCE_SEND,
+                             _wl_interaction_send, ee);
+   wdata->offer_handler =
+     ecore_event_handler_add(ECORE_WL2_EVENT_OFFER_DATA_READY,
+                             _wl_selection_receive, ee);
+   wdata->dnd_leave_handler =
+     ecore_event_handler_add(ECORE_WL2_EVENT_DND_LEAVE,
+                             _wl_selection_dnd_leave, ee);
+   wdata->dnd_motion_handler =
+     ecore_event_handler_add(ECORE_WL2_EVENT_DND_MOTION,
+                             _wl_selection_dnd_motion, ee);
+   wdata->dnd_enter_handler =
+     ecore_event_handler_add(ECORE_WL2_EVENT_DND_ENTER,
+                             _wl_selection_dnd_enter, ee);
+   wdata->dnd_drop_handler =
+     ecore_event_handler_add(ECORE_WL2_EVENT_DND_DROP,
+                             _wl_selection_dnd_drop, ee);
+   wdata->dnd_end_handler =
+     ecore_event_handler_add(ECORE_WL2_EVENT_DATA_SOURCE_END,
+                             _wl_selection_dnd_end, ee);
+
    for (int i = 0; i < ECORE_EVAS_SELECTION_BUFFER_LAST; ++i)
      {
         wdata->selection_data[i].callbacks.available_types = NULL;