staging: gasket: apex: Prefer using the BIT macro
authorSanjana Sanikommu <sanjana99reddy99@gmail.com>
Thu, 28 Mar 2019 14:34:24 +0000 (20:04 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 29 Mar 2019 16:15:55 +0000 (17:15 +0100)
Challenge suggested by coccinelle.

Replace bit shifting on 1 with the BIT(x) macro.
Coccinelle script:

@@
constant c;
@@

-(1 << c)
+BIT(c)

Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gasket/apex_driver.c

index a5da9bb..2be45ee 100644 (file)
@@ -294,7 +294,7 @@ static int apex_enter_reset(struct gasket_dev *gasket_dev)
 
        /*    - Wait for RAM shutdown. */
        if (gasket_wait_with_reschedule(gasket_dev, APEX_BAR_INDEX,
-                                       APEX_BAR2_REG_SCU_3, 1 << 6, 1 << 6,
+                                       APEX_BAR2_REG_SCU_3, BIT(6), BIT(6),
                                        APEX_RESET_DELAY, APEX_RESET_RETRY)) {
                dev_err(gasket_dev->dev,
                        "RAM did not shut down within timeout (%d ms)\n",
@@ -340,7 +340,7 @@ static int apex_quit_reset(struct gasket_dev *gasket_dev)
 
        /*    - Wait for RAM enable. */
        if (gasket_wait_with_reschedule(gasket_dev, APEX_BAR_INDEX,
-                                       APEX_BAR2_REG_SCU_3, 1 << 6, 0,
+                                       APEX_BAR2_REG_SCU_3, BIT(6), 0,
                                        APEX_RESET_DELAY, APEX_RESET_RETRY)) {
                dev_err(gasket_dev->dev,
                        "RAM did not enable within timeout (%d ms)\n",