iio: adc: qcom-spmi-adc5: Suppress probe-deferral error message
authorMarijn Suijten <marijn.suijten@somainline.org>
Fri, 16 Dec 2022 19:09:45 +0000 (20:09 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Wed, 28 Dec 2022 17:19:46 +0000 (17:19 +0000)
Much like 807efb7102e8 ("thermal: qcom-spmi-adc-tm5: suppress
probe-deferral error message") the ADC5 driver also spams a similar
probe-deferral error on startup when a channel is not yet available:

    [    0.343136] qcom-spmi-adc-tm5 1c40000.spmi:pmic@0:adc-tm@3500: get dt data failed: -517

Suppress it by using dev_err_probe instead, which also takes care of
storing the message as reason for deferring.

Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
Reviewed-by: Martin Botka <martin.botka@somainline.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20221216190945.902754-1-marijn.suijten@somainline.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/qcom-spmi-adc5.c

index 821fee6..69cc360 100644 (file)
@@ -894,10 +894,8 @@ static int adc5_probe(struct platform_device *pdev)
        mutex_init(&adc->lock);
 
        ret = adc5_get_fw_data(adc);
-       if (ret) {
-               dev_err(dev, "adc get dt data failed\n");
-               return ret;
-       }
+       if (ret)
+               return dev_err_probe(dev, ret, "adc get dt data failed\n");
 
        irq_eoc = platform_get_irq(pdev, 0);
        if (irq_eoc < 0) {