libs/gst/base/gstcollectpads.c: unref data at the end when we are done with the pad.

Original commit message from CVS:
* libs/gst/base/gstcollectpads.c: (gst_collect_pads_remove_pad):
unref data at the end when we are done with the pad.

diff --git a/ChangeLog b/ChangeLog
index b4656a54261e67d356f7503b0178ac0aae4adb45..edb27a62fdc823b870aaa4f482921cf8879666f6 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2007-01-09  Wim Taymans  <wim@fluendo.com>
+
+       * libs/gst/base/gstcollectpads.c: (gst_collect_pads_remove_pad):
+       unref data at the end when we are done with the pad.
+
 2007-01-08  Tim-Philipp Müller  <tim at centricular dot net>
 
        * docs/gst/gstreamer-sections.txt:

diff --git a/libs/gst/base/gstcollectpads.c b/libs/gst/base/gstcollectpads.c
index 96f921772f1e689c7b635894dffa875dd248f8fc..9a2af8b30d7bc4869ac1be51da399cd2cc084b6f 100644 (file)
--- a/libs/gst/base/gstcollectpads.c
+++ b/libs/gst/base/gstcollectpads.c
@@ -347,9 +347,6 @@ gst_collect_pads_remove_pad (GstCollectPads * pads, GstPad * pad)
       g_slist_delete_link (pads->abidata.ABI.pad_list, list);
   pads->abidata.ABI.pad_cookie++;
 
-  /* clean and free the collect data */
-  unref_data (data);
-
   /* signal waiters because something changed */
   GST_COLLECT_PADS_BROADCAST (pads);
 
@@ -357,6 +354,9 @@ gst_collect_pads_remove_pad (GstCollectPads * pads, GstPad * pad)
   if (!pads->started)
     gst_pad_set_active (pad, FALSE);
 
+  /* clean and free the collect data */
+  unref_data (data);
+
   GST_COLLECT_PADS_PAD_UNLOCK (pads);
 
   return TRUE;