omap4+: Avoid using __attribute__ ((__packed__))
authorAneesh V <aneesh@ti.com>
Thu, 8 Mar 2012 07:20:21 +0000 (07:20 +0000)
committerAlbert ARIBAUD <albert.u.boot@aribaud.net>
Tue, 15 May 2012 06:31:26 +0000 (08:31 +0200)
Avoid using __attribute__ ((__packed__)) unless it's
absolutely necessary. "packed" will remove alignment
requirements for the respective objects and may cause
alignment issues unless alignment is also enforced
using a pragma.

Here, these packed attributes were causing alignment
faults in Thumb build.

Signed-off-by: Aneesh V <aneesh@ti.com>
arch/arm/include/asm/arch-omap4/mux_omap4.h
arch/arm/include/asm/arch-omap5/mux_omap5.h

index 30bfad7..4de7c70 100644 (file)
@@ -34,7 +34,7 @@ struct pad_conf_entry {
 
        u16 val;
 
-} __attribute__ ((packed));
+};
 
 #ifdef CONFIG_OFF_PADCONF
 #define OFF_PD          (1 << 12)
index 993237b..4a6ed8b 100644 (file)
@@ -34,7 +34,7 @@ struct pad_conf_entry {
 
        u16 val;
 
-} __attribute__ ((__packed__));
+};
 
 #ifdef CONFIG_OFF_PADCONF
 #define OFF_PD          (1 << 12)