media: pwc-ctl: remove redundant assignment to variable ret
authorColin Ian King <colin.king@canonical.com>
Fri, 10 Apr 2020 13:50:14 +0000 (15:50 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 21 Apr 2020 11:25:18 +0000 (13:25 +0200)
The variable ret is being initialized with a value that is never read
and it is being updated later with a new value.  The initialization is
redundant and can be removed.

Addresses-Coverity: ("Unused value")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Ezequiel Garcia <ezequiel@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/usb/pwc/pwc-ctrl.c

index 315c55927f5c508df94c895f1107b1cdb3c4d67d..cff64d872058dde55be434743081cc245aca4ed9 100644 (file)
@@ -523,7 +523,7 @@ int pwc_set_leds(struct pwc_device *pdev, int on_value, int off_value)
 #ifdef CONFIG_USB_PWC_DEBUG
 int pwc_get_cmos_sensor(struct pwc_device *pdev, int *sensor)
 {
-       int ret = -1, request;
+       int ret, request;
 
        if (pdev->type < 675)
                request = SENSOR_TYPE_FORMATTER1;