Adjust to the new version of livedump_pid() 51/255851/1
authorKonrad Kuchciak <k.kuchciak@samsung.com>
Wed, 24 Mar 2021 07:56:47 +0000 (08:56 +0100)
committerKonrad Kuchciak <k.kuchciak@samsung.com>
Wed, 24 Mar 2021 07:57:49 +0000 (08:57 +0100)
Change-Id: I198b66f4faf363dfc100127dc491f36cf49fd66f
Signed-off-by: Konrad Kuchciak <k.kuchciak@samsung.com>
src/library/diagnostics.c

index 203a42bbf190e96285f6fb2df003911fb6d5da01..2ccb0f2bfa39df9fb36cfa9691e92e0c3e659ea9 100644 (file)
@@ -793,14 +793,19 @@ int diagnostics_request_bugreport(int pid)
                return DIAGNOSTICS_ERROR_IO_ERROR;
        }
 
-       /*
-        * TODO: livedump_pid() should be changed to return
-        * TIZEN_ERROR_PERMISSION_DENIED in case of missing permission
-        * TIZEN_ERROR_INVALID_PARAMETER in case of no such process
-        */
        ret = livedump_pid(pid > 0 ? pid : 0, reason, report_path, PATH_MAX);
-       if (ret == false)
+       if (ret) {
+               if (ret == TIZEN_ERROR_PERMISSION_DENIED) {
+                       _E("Permission error, check privilege");
+                       return DIAGNOSTICS_ERROR_PERMISSION_DENIED;
+               }
+               if (ret == TIZEN_ERROR_NO_SUCH_PROCESS) {
+                       _E("No such process: %d", pid);
+                       return DIAGNOSTICS_ERROR_INVALID_PARAMETER;
+               }
+               _E("livedump_pid() failed: %d", ret);
                return DIAGNOSTICS_ERROR_IO_ERROR;
+       }
 
        return DIAGNOSTICS_ERROR_NONE;
 }