leds: tlc591xx: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Wed, 26 Aug 2020 14:50:13 +0000 (16:50 +0200)
committerPavel Machek <pavel@ucw.cz>
Wed, 9 Sep 2020 09:20:10 +0000 (11:20 +0200)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
drivers/leds/leds-tlc591xx.c

index 0929f12..1dc1405 100644 (file)
@@ -213,12 +213,10 @@ tlc591xx_probe(struct i2c_client *client,
                led->ldev.max_brightness = TLC591XX_MAX_BRIGHTNESS;
                err = devm_led_classdev_register_ext(dev, &led->ldev,
                                                     &init_data);
-               if (err < 0) {
-                       if (err != -EPROBE_DEFER)
-                               dev_err(dev, "couldn't register LED %s\n",
-                                       led->ldev.name);
-                       return err;
-               }
+               if (err < 0)
+                       return dev_err_probe(dev, err,
+                                            "couldn't register LED %s\n",
+                                            led->ldev.name);
        }
        return 0;
 }