NFC: Elide the value of a UnitAttr within nested attribute dictionaries.

This matches the behavior of the top level attribute dictionary.

PiperOrigin-RevId: 275879828

diff --git a/mlir/lib/IR/AsmPrinter.cpp b/mlir/lib/IR/AsmPrinter.cpp
index 4b29f0d..0200e98 100644 (file)
--- a/mlir/lib/IR/AsmPrinter.cpp
+++ b/mlir/lib/IR/AsmPrinter.cpp
@@ -746,7 +746,13 @@ void ModulePrinter::printAttribute(Attribute attr, bool mayElideType) {
     os << '{';
     interleaveComma(attr.cast<DictionaryAttr>().getValue(),
                     [&](NamedAttribute attr) {
-                      os << attr.first << " = ";
+                      os << attr.first;
+
+                      // The value of a UnitAttr is elided within a dictionary.
+                      if (attr.second.isa<UnitAttr>())
+                        return;
+
+                      os << " = ";
                       printAttribute(attr.second);
                     });
     os << '}';

diff --git a/mlir/test/IR/parser.mlir b/mlir/test/IR/parser.mlir
index d33186a..31452e0 100644 (file)
--- a/mlir/test/IR/parser.mlir
+++ b/mlir/test/IR/parser.mlir
@@ -521,11 +521,14 @@ func @stringquote() -> () {
 
 // CHECK-LABEL: func @unitAttrs
 func @unitAttrs() -> () {
-  // CHECK-NEXT: "foo"() {unitAttr} : () -> ()
+  // CHECK-NEXT: "foo"() {unitAttr}
   "foo"() {unitAttr = unit} : () -> ()
 
-  // CHECK-NEXT: "foo"() {unitAttr} : () -> ()
+  // CHECK-NEXT: "foo"() {unitAttr}
   "foo"() {unitAttr} : () -> ()
+
+  // CHECK-NEXT: "foo"() {nested = {unitAttr}}
+  "foo"() {nested = {unitAttr}} : () -> ()
   return
 }