Move some implementation from header to cpp

- Patch for the comment on the change-id 308437

Change-Id: I670332d39aa606f270792cc35b16da153a480fb8

diff --git a/srcs/server/dl-loader.cpp b/srcs/server/dl-loader.cpp
index fe789358c6131226e7e6d4007c9866d8cb701cb1..11d279f60e1c39dda6a1f7152b3112b171be3c0f 100644 (file)
--- a/srcs/server/dl-loader.cpp
+++ b/srcs/server/dl-loader.cpp
@@ -18,7 +18,9 @@
  * @brief       Implementation of Dynamic Library Loader
  */
 
+#include <dlfcn.h>
 #include <dl-loader.h>
+#include <webauthn-log.h>
 
 namespace WA {
 
@@ -39,4 +41,13 @@ DLLoader::~DLLoader()
         dlclose(m_libraryHandle);
 }
 
+void *DLLoader::ResolveFunction(const std::string &name) noexcept
+{
+    LogDebug("Resolving symbol: " << name << " from " << m_libraryPath);
+    void *sym = dlsym(m_libraryHandle, name.c_str());
+    if (!sym)
+        LogError("Unable to resolve symbol: " << name << " from " << m_libraryPath << ": " << dlerror());
+    return sym;
+}
+
 } // namespace WebAuthn
\ No newline at end of file

diff --git a/srcs/server/dl-loader.h b/srcs/server/dl-loader.h
index 0d4cc2c5cc7e183eb965ec4bb811e924630229ae..b801fc597071092b0508298c85cbd74d3241dee1 100644 (file)
--- a/srcs/server/dl-loader.h
+++ b/srcs/server/dl-loader.h
@@ -20,10 +20,8 @@
 
 #pragma once
 
-#include <dlfcn.h>
 #include <string>
 #include <exception.h>
-#include <webauthn-log.h>
 
 namespace WA {
 
@@ -33,14 +31,7 @@ public:
     explicit DLLoader(std::string path);
     virtual ~DLLoader();
 
-    virtual void *ResolveFunction(const std::string &name) noexcept
-    {
-        LogDebug("Resolving symbol: " << name << " from " << m_libraryPath);
-        void *sym = dlsym(m_libraryHandle, name.c_str());
-        if (!sym)
-            LogError("Unable to resolve symbol: " << name << " from " << m_libraryPath << ": " << dlerror());
-        return sym;
-    }
+    virtual void *ResolveFunction(const std::string &name) noexcept;
 
     template<typename ReturnValue, typename... Args>
     ReturnValue Invoke(const std::string &name, Args... args)