projects / profile / ivi / webkit-efl.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 4d0a585)
All Mac bots occasionally fail tons of media/ sputnik/ and svg/ tests
authortonikitoo@webkit.org <tonikitoo@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 11 Apr 2012 21:27:21 +0000 (21:27 +0000)
committertonikitoo@webkit.org <tonikitoo@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 11 Apr 2012 21:27:21 +0000 (21:27 +0000)
https://bugs.webkit.org/show_bug.cgi?id=83411

Reviewed by Eric Carlson.
Patch by Antonio Gomes <agomes@rim.com>

Fix obvious problems with the test in order to make tests lets
flaky.

* media/nodesFromRect-shadowContent.html:
* platform/gtk/media/nodesFromRect-shadowContent-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog patch | blob | history
LayoutTests/media/nodesFromRect-shadowContent.html patch | blob | history
LayoutTests/platform/gtk/media/nodesFromRect-shadowContent-expected.txt patch | blob | history
LayoutTests/platform/mac/Skipped patch | blob | history

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 0afead7..c102ffd 100644 (file)
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,15 @@
+2012-04-10  Antonio Gomes  <agomes@rim.com>
+
+        All Mac bots occasionally fail tons of media/ sputnik/ and svg/ tests
+        https://bugs.webkit.org/show_bug.cgi?id=83411
+
+        Reviewed by Eric Carlson.
+
+        Fix obvious problems with the test in order to make tests lets flaky.
+
+        * media/nodesFromRect-shadowContent.html:
+        * platform/gtk/media/nodesFromRect-shadowContent-expected.txt:
+
 2012-04-11  Ryosuke Niwa  <rniwa@webkit.org>
 
         fast/dom/dom-parse-serialize.html and dom-parse-serialize-display.html should be text tests
diff --git a/LayoutTests/media/nodesFromRect-shadowContent.html b/LayoutTests/media/nodesFromRect-shadowContent.html
index d55610a..9fdaf7f 100644 (file)
--- a/LayoutTests/media/nodesFromRect-shadowContent.html
+++ b/LayoutTests/media/nodesFromRect-shadowContent.html
@@ -13,11 +13,6 @@
   <script type="text/javascript" charset="utf-8">
     function runTest()
     {
-      if (window.layoutTestController) {
-        layoutTestController.dumpAsText();
-        layoutTestController.waitUntilDone();
-      }
-
       var e = {};
 
       // Set up shortcut access to elements
@@ -42,12 +37,7 @@
 
       var shadow =['-webkit-media-controls-timeline-container', '-webkit-media-controls-play-button', '-webkit-media-controls-panel', '-webkit-media-controls'];
       checkShadowContent(clickX, clickY, 10, 10, 20, 20, shadow);
-
-      if (window.layoutTestController)
-        layoutTestController.notifyDone();
     }
-
-    window.onload = runTest;
   </script>
 </head>
 <body id="body">
@@ -58,6 +48,7 @@
         testExpected("video.controls", null, '!=');
         waitForEvent('canplaythrough', function () {
             runTest();
+            endTest();
         } );
         video.src = findMediaFile("video", "content/test");
     </script>
diff --git a/LayoutTests/platform/mac/Skipped b/LayoutTests/platform/mac/Skipped
index a5c3630..b237969 100644 (file)
--- a/LayoutTests/platform/mac/Skipped
+++ b/LayoutTests/platform/mac/Skipped
@@ -789,8 +789,5 @@ fast/canvas/webgl/array-message-passing.html
 # but not the innerWidth. The test passes on Qt, GTK and Chromium.
 fast/css/align-positioned-object-on-resize.html
 
-# https://bugs.webkit.org/show_bug.cgi?id=83411
-media/nodesFromRect-shadowContent.html
-
 # https://bugs.webkit.org/show_bug.cgi?id=83618
 fast/dom/inline-event-attributes-release.html
Domain: Web Framework / Uncategorized;