mtd: rawnand: meson: Fix a resource leak in init
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 3 Dec 2020 08:39:48 +0000 (11:39 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Dec 2020 10:53:49 +0000 (11:53 +0100)
[ Upstream commit ad8566d3555c4731e6b48823b92d3929b0394c14 ]

Call clk_disable_unprepare(nfc->phase_rx) if the clk_set_rate() function
fails to avoid a resource leak.

Fixes: 8fae856c5350 ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/X8ikVCnUsfTpffFB@mwanda
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mtd/nand/raw/meson_nand.c

index 48e6dac96be6d7ecf4a2e26c3f456c6b1b305e07..1fd7f7024c0b42c5d0c23b611eea9faac0467608 100644 (file)
@@ -1044,9 +1044,12 @@ static int meson_nfc_clk_init(struct meson_nfc *nfc)
 
        ret = clk_set_rate(nfc->device_clk, 24000000);
        if (ret)
-               goto err_phase_rx;
+               goto err_disable_rx;
 
        return 0;
+
+err_disable_rx:
+       clk_disable_unprepare(nfc->phase_rx);
 err_phase_rx:
        clk_disable_unprepare(nfc->phase_tx);
 err_phase_tx: