ice: Remove enable DCB when SW LLDP is activated
authorMichal Swiatkowski <michal.swiatkowski@intel.com>
Thu, 8 Aug 2019 14:39:29 +0000 (07:39 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Wed, 4 Sep 2019 00:14:37 +0000 (17:14 -0700)
Remove code that enables DCB in initialization when SW LLDP is
activated. DCB flag is set or reset before in ice_init_pf_dcb
based on number of TCs. So there is not need to overwrite it.

Setting DCB without checking number of TCs can cause communication
problems with other cards. Host card sends packet with VLAN priority
tag, but client card doesn't strip this tag and ping doesn't work.

Signed-off-by: Michal Swiatkowski <michal.swiatkowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ice/ice_dcb_lib.c

index 021e2e8..e922adf 100644 (file)
@@ -475,7 +475,6 @@ int ice_init_pf_dcb(struct ice_pf *pf, bool locked)
 
                pf->dcbx_cap = DCB_CAP_DCBX_HOST | DCB_CAP_DCBX_VER_IEEE;
                set_bit(ICE_FLAG_DCB_CAPABLE, pf->flags);
-               set_bit(ICE_FLAG_DCB_ENA, pf->flags);
                return 0;
        }