fixed memory freeing if error during listing services

Signed-off-by: Radoslaw Pajak <r.pajak@samsung.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71526

diff --git a/bus/activation.c b/bus/activation.c
index fcb7133722d869b8d51661761e2701d82d195d21..ea48a26f81224c2bfe0bb552c5044250de4653d0 100644 (file)
--- a/bus/activation.c
+++ b/bus/activation.c
@@ -2179,7 +2179,7 @@ bus_activation_list_services (BusActivation *activation,
 
  error:
   for (j = 0; j < i; j++)
-    dbus_free (retval[i]);
+    dbus_free (retval[j]);
   dbus_free (retval);
 
   return FALSE;

diff --git a/bus/services.c b/bus/services.c
index 6f380fac7de56c8097280fe2ccbc710c31c8e543..01a720ed9a1cc1340a2dea322d6a6510bb7e5c40 100644 (file)
--- a/bus/services.c
+++ b/bus/services.c
@@ -368,7 +368,7 @@ bus_registry_list_services (BusRegistry *registry,
   
  error:
   for (j = 0; j < i; j++)
-    dbus_free (retval[i]);
+    dbus_free (retval[j]);
   dbus_free (retval);
 
   return FALSE;