libdvbv5/parse_string: don't free twice

As reported by valgrind, sometimes, it was freeing the same
data twice, with was causing random troubles elsewhere.

Fix it.

Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>

diff --git a/lib/libdvbv5/parse_string.c b/lib/libdvbv5/parse_string.c
index 78c1cea..f7b745e 100644 (file)
--- a/lib/libdvbv5/parse_string.c
+++ b/lib/libdvbv5/parse_string.c
@@ -485,7 +485,10 @@ void parse_string(struct dvb_v5_fe_parms *parms, char **dest, char **emph,
                *dest = realloc(*dest, strlen(*dest) + 1);
 
        if (!len2) {
-               free (tmp2);
+               if (tmp2) {
+                       free (tmp2);
+                       tmp2 = NULL;
+               }
                free (*emph);
                *emph = NULL;
        } else {
@@ -493,7 +496,9 @@ void parse_string(struct dvb_v5_fe_parms *parms, char **dest, char **emph,
                *emph = realloc(*emph, strlen(*emph) + 1);
        }
 
-       free(tmp1);
-       free(tmp2);
+       if (tmp1)
+               free(tmp1);
+       if (tmp2)
+               free(tmp2);
 }