media: vsp1: Document max_width restriction on UDS
authorKieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Fri, 14 Sep 2018 14:26:52 +0000 (10:26 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 17 Sep 2018 18:54:20 +0000 (14:54 -0400)
The UDS is currently restricted based on a partition size of 256 pixels.
Document the actual restrictions, but don't increase the implementation.

The extended partition algorithm may later choose to utilise a larger
partition size to support overlapping partitions which will improve the
quality of the output images.

Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/vsp1/vsp1_uds.c

index 75c6130..27012af 100644 (file)
@@ -342,6 +342,14 @@ static unsigned int uds_max_width(struct vsp1_entity *entity,
                                            UDS_PAD_SOURCE);
        hscale = output->width / input->width;
 
+       /*
+        * The maximum width of the UDS is 304 pixels. These are input pixels
+        * in the event of up-scaling, and output pixels in the event of
+        * downscaling.
+        *
+        * To support overlapping partition windows we clamp at units of 256 and
+        * the remaining pixels are reserved.
+        */
        if (hscale <= 2)
                return 256;
        else if (hscale <= 4)