ARM: More micro-optimization of megamorphic lookup.

Review URL: https://chromiumcodereview.appspot.com/9323004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10599 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

diff --git a/src/arm/stub-cache-arm.cc b/src/arm/stub-cache-arm.cc
index d8fc2e4f8646fc8e64db540dc792f87313f662c2..15c5f4edef1c3696a76259deaab6e868e2d10a00 100644 (file)
--- a/src/arm/stub-cache-arm.cc
+++ b/src/arm/stub-cache-arm.cc
@@ -205,8 +205,9 @@ void StubCache::GenerateProbe(MacroAssembler* masm,
   // Mask down the eor argument to the minimum to keep the immediate
   // ARM-encodable.
   __ eor(scratch, scratch, Operand(flags & mask));
-  // Prefer ubfx to and_ here because the mask is not ARM-encodable.
-  __ Ubfx(scratch, scratch, kHeapObjectTagSize, kPrimaryTableBits);
+  // Prefer and_ to ubfx here because ubfx takes 2 cycles.
+  __ and_(scratch, scratch, Operand(mask));
+  __ mov(scratch, Operand(scratch, LSR, 1));
 
   // Probe the primary table.
   ProbeTable(isolate,
@@ -215,14 +216,15 @@ void StubCache::GenerateProbe(MacroAssembler* masm,
              kPrimary,
              name,
              scratch,
-             kHeapObjectTagSize,
+             1,
              extra,
              extra2);
 
   // Primary miss: Compute hash for secondary probe.
-  __ rsb(scratch, name, Operand(scratch, LSL, kHeapObjectTagSize));
-  __ add(scratch, scratch, Operand(flags));
-  __ Ubfx(scratch, scratch, kHeapObjectTagSize, kSecondaryTableBits);
+  __ sub(scratch, scratch, Operand(name, LSR, 1));
+  uint32_t mask2 = (kSecondaryTableSize - 1) << (kHeapObjectTagSize - 1);
+  __ add(scratch, scratch, Operand((flags >> 1) & mask2));
+  __ and_(scratch, scratch, Operand(mask2));
 
   // Probe the secondary table.
   ProbeTable(isolate,
@@ -231,7 +233,7 @@ void StubCache::GenerateProbe(MacroAssembler* masm,
              kSecondary,
              name,
              scratch,
-             kHeapObjectTagSize,
+             1,
              extra,
              extra2);