vfio/mdev: Use sysfs_emit() to instead of sprintf()
authorBo Liu <liubo03@inspur.com>
Sun, 29 Jan 2023 08:41:17 +0000 (03:41 -0500)
committerAlex Williamson <alex.williamson@redhat.com>
Mon, 30 Jan 2023 19:16:13 +0000 (12:16 -0700)
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: Bo Liu <liubo03@inspur.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/20230129084117.2384-1-liubo03@inspur.com
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
drivers/vfio/mdev/mdev_sysfs.c

index abe3359dd477fc67364084d39141d6018ebad9e0..e4490639d3833e68a4d0b8c9deb50004dfa84290 100644 (file)
@@ -96,7 +96,7 @@ static MDEV_TYPE_ATTR_RO(device_api);
 static ssize_t name_show(struct mdev_type *mtype,
                         struct mdev_type_attribute *attr, char *buf)
 {
-       return sprintf(buf, "%s\n",
+       return sysfs_emit(buf, "%s\n",
                mtype->pretty_name ? mtype->pretty_name : mtype->sysfs_name);
 }