[RTNL]: Improve error codes for unsupported operations
authorThomas Graf <tgraf@suug.ch>
Thu, 5 Apr 2007 21:35:52 +0000 (14:35 -0700)
committerDavid S. Miller <davem@sunset.davemloft.net>
Thu, 26 Apr 2007 05:28:34 +0000 (22:28 -0700)
The most common trigger of these errors is that the
config option hasn't been enable wich would make the
functionality available. Therefore returning EOPNOTSUPP
gives a better idea on what is going wrong.

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/rtnetlink.c

index fa5f938..5266df3 100644 (file)
@@ -862,7 +862,7 @@ static int rtnetlink_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
 
        type = nlh->nlmsg_type;
        if (type > RTM_MAX)
-               return -EINVAL;
+               return -EOPNOTSUPP;
 
        type -= RTM_BASE;
 
@@ -885,7 +885,7 @@ static int rtnetlink_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
 
                dumpit = rtnl_get_dumpit(family, type);
                if (dumpit == NULL)
-                       return -EINVAL;
+                       return -EOPNOTSUPP;
 
                return netlink_dump_start(rtnl, skb, nlh, dumpit, NULL);
        }
@@ -913,7 +913,7 @@ static int rtnetlink_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
 
        doit = rtnl_get_doit(family, type);
        if (doit == NULL)
-               return -EINVAL;
+               return -EOPNOTSUPP;
 
        return doit(skb, nlh, (void *)&rta_buf[0]);
 }