power: supply: max17040: Correct voltage reading
authorJonathan Bakker <xc-racer2@live.ca>
Mon, 4 May 2020 22:12:58 +0000 (15:12 -0700)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Sun, 10 May 2020 20:00:02 +0000 (22:00 +0200)
According to the datasheet available at (1), the bottom four
bits are always zero and the actual voltage is 1.25x this value
in mV.  Since the kernel API specifies that voltages should be in
uV, it should report 1250x the shifted value.

1) https://datasheets.maximintegrated.com/en/ds/MAX17040-MAX17041.pdf

Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/max17040_battery.c

index 8a1f0ee493aac0c67700fe6370ccc8fc61e2a96e..48aa44665e2f1ac66a3681181a1410945560ecf7 100644 (file)
@@ -126,7 +126,7 @@ static void max17040_get_vcell(struct i2c_client *client)
 
        vcell = max17040_read_reg(client, MAX17040_VCELL);
 
-       chip->vcell = vcell;
+       chip->vcell = (vcell >> 4) * 1250;
 }
 
 static void max17040_get_soc(struct i2c_client *client)